[Libguestfs] [PATCH libnbd 1/4] lib: Move nbd_aio_is_* function impls to separate source file.
Eric Blake
eblake at redhat.com
Wed Jun 5 14:25:04 UTC 2019
On 6/5/19 6:15 AM, Richard W.M. Jones wrote:
> Simple code motion.
> ---
> lib/Makefile.am | 1 +
> lib/aio.c | 78 -----------------------------------
> lib/is-state.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 106 insertions(+), 78 deletions(-)
>
> +++ b/lib/is-state.c
> @@ -0,0 +1,105 @@
> +#include <config.h>
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <stdbool.h>
> +#include <errno.h>
> +#include <inttypes.h>
Do you really need all of these? At least errno.h looks spurious after
a quick glance.
ACK.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190605/e141385a/attachment.sig>
More information about the Libguestfs
mailing list