[Libguestfs] [nbdkit PATCH 0/2] Few rust plugin fixups/nitpicks

Eric Blake eblake at redhat.com
Tue Jun 11 15:52:34 UTC 2019


On 6/11/19 6:25 AM, Martin Kletzander wrote:
> There are few more things that could be cleaned up related to the coding style
> and other things, like explicitly specifying the abi style after "extern"
> (i.e. `extern "C" fn` instead of `extern fn`), but since those are configurable
> in rustfmt config, I'm not sure whether the config needs to be added or
> complying with the defaults should be the priority.  But this was just something
> I stumbled upon when I saw some warnings during build, nothing more.
> 
> Martin Kletzander (2):
>   rust: Do not use deprecated integer types
>   rust: Remove libc dependency
> 
>  plugins/rust/Cargo.toml.in       |  1 -
>  plugins/rust/examples/ramdisk.rs | 15 ++++++-------
>  plugins/rust/src/lib.rs          | 37 +++++++++++++++-----------------
>  3 files changed, 24 insertions(+), 29 deletions(-)

I'm no Rust expert, but it doesn't break the build and doesn't look bad
to me. Pushed.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190611/00868a44/attachment.sig>


More information about the Libguestfs mailing list