[Libguestfs] [PATCH libnbd 4/4] lib: Atomically update h->state when leaving the locked region.

Richard W.M. Jones rjones at redhat.com
Sat Jun 8 17:50:34 UTC 2019


On Sat, Jun 08, 2019 at 06:45:53PM +0100, Richard W.M. Jones wrote:
> > > @@ -2866,8 +2866,11 @@ let generate_lib_api_c () =
> > 
> > As said above, I think you're still missing a change at the beginning of
> > the wrapper that grabs the lock to do the state check after the lock.
> 
> AFAIK the code is safe now?  I'm not sure what you mean by this.

Ignore this, your review of the updated patch makes it clear what you
mean.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html




More information about the Libguestfs mailing list