[Libguestfs] [libnbd PATCH] Fix building with for ocaml < 4.06.0

[Martin Kletzander]

On Wed, Jun 12, 2019 at 08:02:06AM -0500, Eric Blake wrote:
>On 6/12/19 6:27 AM, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>
>> Notes:
>>     This is the simplest solution suggested to me by Rich and it works.
>>
>>     Most of autotools are not friends with me, so the other approach I tried, with
>>     requiring at least OCaml 4.05.0, having this fix in only for OCaml < 4.06.0 and
>>     properly detecting and reporting that, was a bit ugly.
>
>I prefer the lightweight approach - all the more configure.ac does is
>add the ability to do #ifdef-ery probing on things that don't originally
>come with enough #ifdef witnesses; but here, the absence of Bytes_val is
>all the more that you would probe for in configure.ac, making it not
>worth the effort to add yet another macro just to work around the problem.
>
>Which platform are you compiling on, and what OCaml version are you
>using?  That said, I don't see any reason to not commit this patch.
>

Gentoo, OCaml 4.05.0 in the system, but 4.07.0 through opam.  I noticed I cannot
build it when I added it as a package and wanted to install it into the system.

>--
>Eric Blake, Principal Software Engineer
>Red Hat, Inc.           +1-919-301-3226
>Virtualization:  qemu.org | libvirt.org
>



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190612/80b712c9/attachment.sig>