[Libguestfs] [libnbd PATCH 0/2] Tighten URI parser

Eric Blake eblake at redhat.com
Wed Jun 26 02:09:58 UTC 2019


I'm not sure whether we want to go with just the first patch (reject
nbd:unix:/path but still accept nbd:/path), or squash the two in order
to go with the second (reject both abbreviated forms, and require
scheme://...).  Either way, though, nbdkit -U - --run '$nbd' will now
error out rather than inadvertently connect over TCP to
localhost:10809 instead of the intended Unix connection (and in the
meantime, you want to use --run '$unixsocket', or maybe we should
teach nbdkit to support --run '$uri').

Eric Blake (2):
  uri: Reject nbd:unix:/path/to/socket as invalid URI
  uri: Reject nbd:unix:/path/to/socket as invalid URI

 lib/connect.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

-- 
2.20.1




More information about the Libguestfs mailing list