[Libguestfs] [libnbd PATCH 0/2] Tighten URI parser

[Martin Kletzander]

On Tue, Jun 25, 2019 at 09:09:58PM -0500, Eric Blake wrote:
>I'm not sure whether we want to go with just the first patch (reject
>nbd:unix:/path but still accept nbd:/path), or squash the two in order
>to go with the second (reject both abbreviated forms, and require
>scheme://...).  Either way, though, nbdkit -U - --run '$nbd' will now
>error out rather than inadvertently connect over TCP to
>localhost:10809 instead of the intended Unix connection (and in the
>meantime, you want to use --run '$unixsocket', or maybe we should
>teach nbdkit to support --run '$uri').
>

Oh, I get it now. So "nbd:unix:/path" is a valid URL without authority where the
path is "unix:/path".  Well, TIL =)
It is nicely visible here:

  https://tools.ietf.org/html/rfc3986#section-3

These patches are fine from my standpoint, although I must say thinking about
the above as defined in the RFC makes me re-evaluate my feelings about it.
Having URI without authority just use a local file (socket) makes sense now.
Even having the unix: prefix to show that it is a UNIX socket seems sensible.
At least unless you realize that having an actual URI it makes sense to have
that as a part of the scheme, as is customary.

What I am trying to say is that maybe just the first patch is enough.  When
people want to just write, for example nbd:/tmp/my_nbd.sock by hand, it is
easier than typing the whole nbd+unix:?socket=/tmp/my_nbd.sock.  On the other
hand, how often do you need to write it manually...

Anyway, I don't really have strong feelings about this, so whatever you choose
is fine as long as nbd:unix:/path does not try connecting to localhost over
network =)

>Eric Blake (2):
>  uri: Reject nbd:unix:/path/to/socket as invalid URI
>  uri: Reject nbd:unix:/path/to/socket as invalid URI

The second one should say "Reject nbd:/path/to/socket as invalid URL", I guess.


Thank you.

>
> lib/connect.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
>-- 
>2.20.1
>
>_______________________________________________
>Libguestfs mailing list
>Libguestfs at redhat.com
>https://www.redhat.com/mailman/listinfo/libguestfs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190626/69ee5c4a/attachment.sig>