[Libguestfs] [PATCH v2 2/3] v2v: allow alternative directories for distributions

[Pino Toscano]

On Thursday, 21 March 2019 10:52:54 CET Pino Toscano wrote:
> > @@ -340,9 +354,9 @@ and copy_from_virtio_win g inspect srcdir destdir filter missing =
> >        g2#launch ();
> >        let vio_root = "/" in
> >        g2#mount_ro "/dev/sda" vio_root;
> > -      let srcdir = vio_root ^ "/" ^ srcdir in
> > -      if not (g2#is_dir srcdir) then missing ()
> > -      else (
> > +      let srcdirs = List.map ((^) (vio_root ^ "/")) srcdirs in
> 
> Paths in the appliance are always with '/', so you cannot use (^) to
> join appliance paths (as (^) expands to the path separator of the OS
> where virt-v2v runs).
> In practice it is not a problem, since so far libguestfs runs on Unix
> platforms only.  However, it would be nice to get it correct, so there
> is less potential confusion between host paths, and appliance paths.

Oops, disregard this -- I confused it with (//) ...

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190322/72e2488d/attachment.sig>