[Libguestfs] [PATCH nbdkit 2/2] server: Split out NBD protocol code from connections code.

[Eric Blake]

On 3/18/19 12:02 PM, Richard W.M. Jones wrote:
> The code handling the NBD protocol was located in the same file as the
> code handling connections, for not really any reason except historical.
> 
> This is quite a large code movement which splits out the protocol code
> into four new files:
> 
> server/protocol-handshake.c           initial handshake
> server/protocol-handshake-newstyle.c     "        "     (newstyle)
> server/protocol-handshake-oldstyle.c     "        "     (oldstyle)
> server/protocol.c                     requests and replies
> 
> This also renames functions more logically and gets rid of functions
> named with leading underscores.

And it reminds me that I still need to make time to write patches to
move server/protocol* into util, so that the nbd plugin can make use of
it with a proper -l to a convenience library rather than its current
hack that abuses out-of-directory files and causes automake to warn:

plugins/nbd/Makefile.am:39: warning: source file
'$(top_srcdir)/server/protostrings.c' is in a subdirectory,

At any rate, this series makes sense and looks good to go.  As you said,
it's big, but mechanical.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190318/b255896c/attachment.sig>