[Libguestfs] [PATCH 01/11] v2v: Move have_selinux to utils.

Pino Toscano ptoscano at redhat.com
Fri May 10 14:12:37 UTC 2019


On Monday, April 8, 2019 1:10:07 PM CEST Richard W.M. Jones wrote:
> This is not quite a neutral refactoring, because it means we now run
> the getenforce command every time virt-v2v starts up.  However it's a
> trivial command that reads a single /sys file and it can't fail even
> if the command is missing or on platforms that know nothing about
> SELinux.
> ---

Alternative approach to retain the current behaviour:
- add the proposed "have_selinux" statement as function in Utils, maybe
  with a better name such as "is_selinux_enforcing"
- assigning to the have_selinux variables the result of
  is_selinux_enforcing ()

I see this patch was already pushed though ...

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190510/166f1f9e/attachment.sig>


More information about the Libguestfs mailing list