[Libguestfs] [nbdkit PATCH v2 23/24] filters: Pass through .can_cache for remaining filters

Eric Blake eblake at redhat.com
Thu May 16 03:58:13 UTC 2019


The previous patches finished accounting for all filters that must
modify behavior of caching. All remaining filters can pass through
.can_cache to the plugin.

Signed-off-by: Eric Blake <eblake at redhat.com>
---
 server/filters.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/server/filters.c b/server/filters.c
index 430d515..3bd91fe 100644
--- a/server/filters.c
+++ b/server/filters.c
@@ -602,11 +602,8 @@ filter_can_cache (struct backend *b, struct connection *conn)

   if (f->filter.can_cache)
     return f->filter.can_cache (&next_ops, &nxdata, handle);
-  /* FIXME: Default to f->backend.next->can_cache, once all filters
-     have been audited */
   else
-    return NBDKIT_CACHE_NONE;
-  return f->backend.next->can_cache (f->backend.next, conn);
+    return f->backend.next->can_cache (f->backend.next, conn);
 }

 static int
-- 
2.20.1




More information about the Libguestfs mailing list