[Libguestfs] [PATCH libnbd 1/3] states: Factor out common code for setting export size and eflags.
Eric Blake
eblake at redhat.com
Thu May 23 12:33:10 UTC 2019
On 5/23/19 4:32 AM, Richard W.M. Jones wrote:
> Simple refactoring.
> ---
> generator/states-newstyle-opt-export-name.c | 12 +++++------
> generator/states-newstyle-opt-go.c | 13 ++++++------
> generator/states-oldstyle.c | 10 +++-------
> lib/flags.c | 22 +++++++++++++++++++++
> lib/internal.h | 5 +++++
> 5 files changed, 42 insertions(+), 20 deletions(-)
ACK. Odd that the diffstat doesn't match that this does look simpler in
the end. It also gives us a common hook point to enforce (which we may
want - although we're still deciding that) that secondary multi-conn
connections come up with the same eflags as the first.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190523/11360298/attachment.sig>
More information about the Libguestfs
mailing list