[Libguestfs] [PATCH v2 RESEND] direct, fish: add command launch_blocksize

Richard W.M. Jones rjones at redhat.com
Tue Nov 12 09:11:58 UTC 2019


On Tue, Nov 05, 2019 at 09:49:08AM +0100, Tuan Hoang wrote:
> Add a new launch command for direct backend, which allows specifying the
> blocksize to the disks. The name is `launch_blocksize`, accompanied alias is
> `run-blocksize`.
> 
> Example:
> 
> $ guestfish --listen -a raw.img
> $ guestfish --remote -- launch_blocksize 4096

NACK

TBH, I don't understand why this new command is needed.

A considerably simpler and more obvious way is to follow what the
--format option does already.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list