[Libguestfs] [PATCH 2/2] options: Allow multiple --key parameters and default keys.

[Pino Toscano]

On Tuesday, 12 November 2019 19:35:12 CET Richard W.M. Jones wrote:
> This allows multiple --key parameters on the command line to match a
> single device.  This could either be specified as:
> 
>   tool --key /dev/sda1:key:trykey1 --key /dev/sda1:key:trykey2
> 
> which would try "trykey1" and "trykey2" against /dev/sda1.

This seems OK for me, so you can attempt multiple keys for a device.

> And/or you can specify default keys which are tried against each
> device (after more specific keys fail), eg:
> 
>   tool --key :key:defaultkey1 --key :key:defaultkey2
> 
> which would try "defaultkey1" and "defaultkey2" against all devices.

However I do not see the point in this: IMHO you better make it explicit
which key is used for a certain device. Also, this makes it possible so
in case of two similar guests like:
- /dev/sda1 with key "key1", and /dev/sda2 with key "key2"
- /dev/sda1 with key "key2", and /dev/sda2 with key "key1"
the above command like will work in the same way, with no indication of
which key was successfully used for which device -- so you can silently
swap the first guest for the second with no changes to the v2v command
line...
What's the use case for this?

Please split this patch in two:
- multiple keys for the same device
- keys for all devices

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20191115/1c68513b/attachment.sig>