[Libguestfs] [PATCH libguestfs 1/3] podwrapper: __INCLUDE:file.pod__ and __VERBATIM:file.txt__ in POD files.

Pino Toscano ptoscano at redhat.com
Wed Nov 27 12:31:53 UTC 2019


On Wednesday, 27 November 2019 13:27:21 CET Pino Toscano wrote:
> BTW is the colon-separated value for --path needed? Reading the other
> two patches of this series, I see the values are only a single
> directory every time. In this case, the proposal above can be
> simplified as:
> 
>    my @paths = ('.');
>    [...]
>    GetOptions(
>        "path=s" => \@paths,
>    [...]

Self-correction: there is one occurrence of that in patch #3:

diff --git a/fish/Makefile.am b/fish/Makefile.am
index dff56b2e2..932c66398 100644
--- a/fish/Makefile.am
+++ b/fish/Makefile.am
@@ -201,7 +201,7 @@ stamp-guestfish.pod: guestfish.pod guestfish-actions.pod guestfish-commands.pod
        $(PODWRAPPER) \
          --man guestfish.1 \
          --html $(top_builddir)/website/guestfish.1.html \
-         --path $(srcdir) \
+         --path $(srcdir):$(top_srcdir)/common/options \
          --license GPLv2+ \
          --warning ro-option \
          $<

However it can be easily changed to just add
    --path $(top_srcdir)/common/options
to the podwrapper arguments.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20191127/937b58d0/attachment.sig>


More information about the Libguestfs mailing list