[Libguestfs] [PATCH] v2v: Optimize convert for images with small holes

[Richard W.M. Jones]

On Fri, Nov 01, 2019 at 10:56:18PM +0100, Nir Soffer wrote:
> diff --git a/v2v/v2v.ml b/v2v/v2v.ml
> index 4655b883..03590c9e 100644
> --- a/v2v/v2v.ml
> +++ b/v2v/v2v.ml
> @@ -741,6 +741,7 @@ and copy_targets cmdline targets input output =
>          (if not (quiet ()) then [ "-p" ] else []) @
>          [ "-n"; "-f"; "qcow2"; "-O"; t.target_format ] @
>          (if cmdline.compressed then [ "-c" ] else []) @
> +        [ "-S"; "64k" ] @

I kind of wonder if we should make this something that the output mode
can set.  However I don't think it's a big deal since (a) 64K is the
same as the standard qcow2 cluster size so it won't affect qcow2
outputs and (b) it's not a particularly large size even for raw
outputs.  Therefore:

ACK

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top