[Libguestfs] [PATCH 05/18] rhv-upload: Ensure http is closed in close()

Nir Soffer nirsof at gmail.com
Sun Nov 17 23:04:27 UTC 2019


After failure we forgot to close the http connection.
---
 v2v/rhv-upload-plugin.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
index 3fb3091a9..5bdfdf49f 100644
--- a/v2v/rhv-upload-plugin.py
+++ b/v2v/rhv-upload-plugin.py
@@ -506,6 +506,8 @@ def close(h):
     # plugin exits.
     sys.stderr.flush()
 
+    http.close()
+
     # If the connection failed earlier ensure we clean up the disk.
     if h['failed']:
         delete_disk_on_failure(h)
@@ -513,8 +515,6 @@ def close(h):
         return
 
     try:
-        http.close()
-
         disk = h['disk']
         transfer_service = h['transfer_service']
 
-- 
2.21.0





More information about the Libguestfs mailing list