[Libguestfs] [PATCH 0/2] rhv-upload: Complete refactoring

[Martin Kletzander]

On Wed, Nov 20, 2019 at 01:19:31AM +0200, Nir Soffer wrote:
>Fix NameError introduced by inocomplete change to extract create_transfer() by
>extracting cancel_transfer() function.
>
>Finally extract finallize_transfer() function, dealing with the poorly
>documented and over complicated oVirt SDK.
>
>Tested with:
>libguestfs-1.40.2-4.fc30.x86_64
>nbdkit-1.12.8-1.fc30.x86_64
>
>Tested flows:
>- Successful import
>- Error in close() - by injecting long sleep in vdsm verifaction step
>- Error in close() - by injecting error in vdsm verification step
>- Error in open() - by injecting error in imageio OPTIONS handler
>- Error in zero() - by injecting error in imageio PATCH handler
>- Error in flush() - by injecting error in imageio PATCH handler
>
>Nir Soffer (2):
>  rhv-upload: Extract cancel_transfer() function
>  rhv-upload: Extract finalize_transfer() function
>

Both look OK to me, although I have not tested the second one yet.  There are
just a few typos in the second patch that could get some s/changed/change/
treatment, but it's so minor I don't want send another mail just for that =)

> v2v/rhv-upload-plugin.py | 118 ++++++++++++++++++++++++++-------------
> 1 file changed, 78 insertions(+), 40 deletions(-)
>
>-- 
>2.21.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20191120/4c4fd0f7/attachment.sig>