[Libguestfs] [nbdkit PATCH 0/5] Counterproposal for python v2 interfaces

Richard W.M. Jones rjones at redhat.com
Tue Nov 26 19:41:30 UTC 2019


Thanks for posting this.  Some inconclusive comments in no particular
order:

I don't have enough experience to judge whether or not kwargs are more
Pythonic.  My impression is that bitmasks are used in the library and
so are kwargs, and kwargs are used more often, and bitmasks seem to be
used mainly in lowlevel functions where the Python code is talking to C.

About API_VERSION, I think we will need that in order to implement
pread into a buf, unless we implement both pread() (returning buf) and
a second call preadinto(..., buf, ...).  In my current patch series I
only implemented pread(..., buf, ...) so API_VERSION is definitely
required by mine.

>From the virt-v2v point of view, performance is the most important
factor for us.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list