[Libguestfs] [PATCH] v2v: Output saved overlays in a machine-readable fashion

[Richard W.M. Jones]

On Fri, Oct 11, 2019 at 01:29:53PM +0100, Richard W.M. Jones wrote:
> However there are some action items:
> 
> (1) do_convert does not need the source parameter.  I think it could
> just be passed the .s_name field instead.
> 
> (2) output#prepare_targets doesn't really need the source struct, but
> could probably get away with being passed just the .s_name field and
> maybe .s_hypervisor.

OK I fixed (1) and (2) already - trivial commits pushed.

> (3) source.s_disks and the rest of the source struct seem to have
> sufficiently different usage that we can consider separating them.

I'll have a look at this.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/