[Libguestfs] [PATCH nbdkit] tests: Convert some tests to use nbdsh instead of qemu-io.

Eric Blake eblake at redhat.com
Wed Sep 11 13:48:28 UTC 2019


On 9/11/19 5:40 AM, Richard W.M. Jones wrote:
> Very much a work in progress as there are still many tests using
> qemu-io which are candidates for conversion.
> 
> You'll notice at the end of test-full.sh that the new test has some
> duplicated code which looks as if it ought to be refactored into a
> Python function.  When I tried to do that, I got loads of strange
> Python problems which may indicate bugs in nbdsh itself or problems
> with my understanding of how Python works, but I wasn't sure how to
> fix it.  The current implementation works.

I'm not sure if I'd spot the problem, but I'd least need to see your
alternative that didn't work before I can tell for sure :)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190911/f74d4c6c/attachment.sig>


More information about the Libguestfs mailing list