[Libguestfs] [PATCH] v2v: -o rhv-upload: add -oo rhv-disk-uuid option

[Martin Kletzander]

On Thu, Sep 19, 2019 at 12:38:41PM +0200, Pino Toscano wrote:
>This way it is possible to override the UUIDs of the uploaded disks,
>instead of letting RHV generate them.
>
>This can be useful to force certain UUIDs, and to specify the disks in
>--no-copy mode (which now can be used).
>---
> v2v/output_rhv_upload.ml    | 43 ++++++++++++++++++++++++++++++++-----
> v2v/rhv-upload-plugin.py    |  2 ++
> v2v/virt-v2v-output-rhv.pod | 23 ++++++++++++++++++++
> 3 files changed, 63 insertions(+), 5 deletions(-)
>
>diff --git a/v2v/virt-v2v-output-rhv.pod b/v2v/virt-v2v-output-rhv.pod
>index 651f61dae..c91477f62 100644
>--- a/v2v/virt-v2v-output-rhv.pod
>+++ b/v2v/virt-v2v-output-rhv.pod
>@@ -9,6 +9,7 @@ virt-v2v-output-rhv - Using virt-v2v to convert guests to oVirt or RHV
>                         [-oo rhv-cafile=FILE]
>                         [-oo rhv-cluster=CLUSTER]
>                         [-oo rhv-direct]
>+                        [-oo rhv-disk-uuid=UUID ...]
>                         [-oo rhv-verifypeer]
>
>  virt-v2v [-i* options] -o rhv -os [esd:/path|/path]
>@@ -104,6 +105,28 @@ F</etc/pki/ovirt-engine/ca.pem> on the oVirt engine.
>
> Set the RHV Cluster Name.  If not given it uses C<Default>.
>
>+=item I<-oo rhv-disk-uuid=>C<UUID>
>+
>+This option is used to specify UUIDs for the disks when creating the
>+virtual machine.  However, please note that:
>+

Please add some information that this is optional.  This way it sounds like it
is mandatory.

ACK with that.  It is way better implementation than I have.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190919/811f61b8/attachment.sig>