[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit v2 3/3] tests: Add a simple test of nbdkit_export_name.



On 9/12/19 4:41 PM, Eric Blake wrote:

> 
> Hmm - instead of making the handle be the name of a temporary file that
> contains the export name, you could just make the handle _be_ the export
> name:
> 

> or bypass dd by exploiting your knowledge of the client:
> pread)
>   if test $4.$3 = "0.${#2}"; then
>     printf %s "$2"
>   else
>     echo "EINVAL unexpected alignment" >&2
>   fi

Now that I actually tested my ideas, I see I missed an 'exit 1' on the
unexpected alignment branch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]