[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/8] v2v: -o rhv-upload: split vmcheck out of precheck



On Mon, Sep 16, 2019 at 07:13:44PM +0200, Pino Toscano wrote:
> Split the VM existance check out of the precheck script to a new vmcheck
> script, and invoke that in #prepare_targets.  Invoke the precheck script
> in #precheck, as now it can be run with only values of command line
> options.
> 
> This does not change which checks are performed; however, an invalid
> cluster name will make virt-v2v fail way earlier (even before connecting
> to the source).

It's only cosmetic but you might want to change:

> +(* virt-v2v
> + * Copyright (C) 2018 Red Hat Inc.

to "2018-2019" (in a few places).

The patch makes sense, so:

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]