[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/8] v2v: -o rhv-upload: improve lookup of specified resources (RHBZ#1612653)



On Mon, Sep 16, 2019 at 07:13:46PM +0200, Pino Toscano wrote:
> -    (* We don't have the storage domain UUID, but instead we write
> -     * in a magic value which the Python code (which can get it)
> -     * will substitute.
> -     *)
> -    let sd_uuid = "@SD_UUID@" in
> +    (* The storage domain UUID. *)
> +    let sd_uuid =
> +      match rhv_storagedomain_uuid with
> +      | None -> assert false
> +      | Some uuid -> uuid in

Nice!

ACK patches 2 & 3.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]