[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit v2 1/4] server: Replace another memset with a call to reset_b_conn_handle.



On 9/19/19 9:33 AM, Richard W.M. Jones wrote:
> Updates commit 5cdf4d6c89bdb802be234f2fccc8157b7228b546
> and commit a6b88b195a959b17524d1c8353fd425d4891dc5f.
> ---
>  server/backend.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/server/backend.c b/server/backend.c
> index 64dbf7d..6c102f9 100644
> --- a/server/backend.c
> +++ b/server/backend.c
> @@ -209,8 +209,7 @@ backend_close (struct backend *b, struct connection *conn)
>    debug ("%s: close", b->name);
>  
>    b->close (b, conn);
> -  memset (h, -1, sizeof *h);
> -  h->handle = NULL;
> +  reset_b_conn_handle (h);
>  }

ACK.  Needed because our mails have been crossing today :)

I'm in the process of backporting the assertion failure; branch-1.14 is
complete, branch-1.12 should be easier as it is closer to what
branch-1.14 used (neither branch has backend.c, and thus are not
impacted by the churn we've had here).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]