[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit v3 2/3] Add new retry filter.



On Thu, Sep 19, 2019 at 11:32:47AM -0500, Eric Blake wrote:
> On 9/19/19 10:26 AM, Richard W.M. Jones wrote:
> > +  else if (strcmp (key, "retry-delay") == 0) {
> > +    if (sscanf (value, "%d", &initial_delay) != 1 || initial_delay <= 0) {
> 
> sscanf("%d") cannot detect overflow; should this use strtol with errno
> checking instead?

Can we not fix POSIX :-?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]