[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit v3 3/3] retry: Add a test of this filter.



On 9/19/19 12:04 PM, Richard W.M. Jones wrote:
> On Thu, Sep 19, 2019 at 11:12:23AM -0500, Eric Blake wrote:
>>> +    open)
>>> +        # Count how many times the connection is (re-)opened.
>>> +        i=`cat retry-reopen-fail-open-count`
>>
>> $() is nicer than ``, but even better is just:
>>
>> read i retry-reopen-fail-open-count
> 
> Did you mean:
> 
> read i < retry-reopen-fail-open-count

Yes. Thanks for fixing my typo.

> 
> Unfortunately it fails when the file does not exist.  (We could
> pre-create the files though).

Yes, or even pre-populate it to contain '0' instead of being empty, if
that makes it easier to track what it is doing.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]