[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [PATCH nbdkit 0/4] common/protocol: Unify public <nbd-protocol.h>



The cover letter was rather brief, let me try to explain this change
some more ...

When we created libnbd, we needed the definitions of various NBD
protocol things (like protocol message layouts, constants etc).  We
copied a header file from nbdkit which provided these.  Over time this
header file has diverged from nbdkit's copy.

In fact the libnbd one has been generally enhanced over the nbdkit
version:

 - All symbols in libnbd's copy are prefixed by NBD_ or nbd_.

 - More coverage of the protocol.

It would be good, not just for nbdkit/libnbd but for other projects,
if we could unify these two files again and publish a liberally
licensed copy as /usr/include/nbd-protocol.h.

This commit series does this for nbdkit.

For libnbd there is an associated patch which just synchronizes the
two files.  I propose that we eventually change libnbd so that it uses
the public (ie. nbdkit) version, but could fall back to an internal
copy if the public version does not exist (so that libnbd doesn't need
to depend on nbdkit).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]