[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [nbdkit PATCH v2 0/7] Spec compliance patches



Since the v1 series (0/4, at [1]), I've applied patches 1 and 2,
rewritten patch 3 [Forbid NUL in export and context names] into patch
4 here, patch 4 there turned into patch 6 here, and everything else
here is new.

[1]https://www.redhat.com/archives/libguestfs/2019-September/msg00180.html

I don't know if there is a handy reusable function for checking
whether a string contains valid UTF-8 while still complying with our
licensing, so for now I don't bother to check that.  But fixing this
meant I also proposed a qemu 4.2 patch on export name length:
https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg06925.html so
part of the test I added only really covers nbdkit when using qemu
4.1, because otherwise qemu fails early without involving nbdkit.

Eric Blake (7):
  server: Reject -e with too long of a name
  server: Expose -e in $exportname during --run
  server: Switch to fixed-length conn->exportname
  server: Improve check of string validity
  server: Allow longer NBD_OPT
  server: Fix OPT_GO on different export than SET_META_CONTEXT
  server: Better newstyle .open failure handling

 docs/nbdkit-captive.pod              |  12 ++-
 server/internal.h                    |   4 +-
 server/Makefile.am                   |   1 +
 server/captive.c                     |  22 ++++-
 server/connections.c                 |   7 --
 server/main.c                        |   6 ++
 server/protocol-handshake-newstyle.c | 117 ++++++++++++++++++++-------
 server/protocol-handshake-oldstyle.c |   3 +
 tests/Makefile.am                    |   2 +
 tests/test-long-name.sh              | 101 +++++++++++++++++++++++
 10 files changed, 231 insertions(+), 44 deletions(-)
 create mode 100755 tests/test-long-name.sh

-- 
2.21.0


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]