[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit v2 1/4] common/include: Add function for subtracting struct timeval.



On Mon, Sep 30, 2019 at 11:24:14AM -0500, Eric Blake wrote:
> On 9/28/19 3:02 PM, Richard W.M. Jones wrote:
> >---
> >  common/include/test-tvdiff.c | 75 +++++++++++++++++++++++++++++-------
> >  common/include/tvdiff.h      | 13 ++++++-
> >  2 files changed, 74 insertions(+), 14 deletions(-)
> >
> 
> ACK
> 
> 
> >  int
> >-main (void)
> >+main (int argc, char *argv[])
> 
> Not sure this part matters, but doesn't hurt either.

It's not very obvious, but it's needed because the TEST_* macros use
argv[0].

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]