[Libguestfs] [supermin PATCH 3/4] Extend modes with list of outputs

Pino Toscano ptoscano at redhat.com
Fri Apr 3 14:55:42 UTC 2020


On Friday, 3 April 2020 13:50:09 CEST Richard W.M. Jones wrote:
> We actually document that --if-newer can only be used in build mode.
> It sort of makes no sense in prepare mode.  So shouldn't this just
> give an error (either here, or earlier) if we're in prepare mode?

Should we error out, or simply ignore it like done for other options
specific to a certain mode (eg --host-cpu)?

Your note also made me discover a bug related to that option:

  (on Fedora)
  $ touch filesystem
  $ supermin --prepare -o foo --if-newer -v filesystem
  supermin: version: 5.2.0
  supermin: rpm: detected RPM version 4.15
  supermin: rpm: detected RPM architecture x86_64
  supermin: package handler: fedora/rpm
  supermin: prepare: filesystem
  [etc..]
  $ supermin --prepare -o foo --if-newer -v filesystem
  supermin: version: 5.2.0
  supermin: rpm: detected RPM version 4.15
  supermin: rpm: detected RPM architecture x86_64
  supermin: package handler: fedora/rpm
  supermin: if-newer: output does not need rebuilding

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200403/a75f3e1b/attachment.sig>


More information about the Libguestfs mailing list