[Libguestfs] [v2v PATCH 2/2] Consolidate handling of temporary files/dirs

Richard W.M. Jones rjones at redhat.com
Tue Apr 7 08:18:39 UTC 2020


On Mon, Apr 06, 2020 at 05:40:45PM +0200, Pino Toscano wrote:
> Create two temporary directories for all the files created during the
> virt-v2v run:
> 1) tmpdir, created as $TMPDIR/virt-v2v.XXXXXX, for all the small files
> 2) cachedir, created as $LIBGUESTFS_CACHEDIR/virt-v2v.XXXXXX, for the
>    big files (e.g. disks)
> This way there is no need to manually schedule all the temporary files
> and directories for removal when the application quits.

So part of the idea here is fine - having a single tmpdir for small
files and another single tmpdir for large files.  That's a worthwhile
improvement on what I posted.

However the greater problem is this doesn't fix the containers problem
as far as I can see.  We still are unable to separate out the location
of the libguestfs appliance from the large temporary overlay files
created by virt-v2v.

So I don't understand how this helps at all, and therefore at this
time I cannot approve it.

I'm installing another kubernetes install locally with NFS PVs so
hopefully I will have a better understanding of exactly what the
problem is later today.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list