[Libguestfs] [PATCH nbdkit v2 2/3] iso: Implement this plugin using fileops (read-only).

[Eric Blake]

On 4/9/20 4:31 PM, Eric Blake wrote:
> On 4/9/20 4:27 PM, Eric Blake wrote:
>> On 4/9/20 3:36 AM, Richard W.M. Jones wrote:
>>> The plugin should now support pre-fetch and extents, although most ISO
>>> images will be non-sparse so extents probably isn't that useful.
>>
>> True, but it can't hurt ;)
>>
>>> ---
>>>   plugins/iso/Makefile.am |  4 +-
>>>   plugins/iso/iso.c       | 99 +++++++++++++++++++----------------------
>>>   2 files changed, 48 insertions(+), 55 deletions(-)
>>>
>>
> 
> Oops, you forgot to set
> #define NBDKIT_API_VERSION 2

Scratch that, I see you did set it (I was grepping for it but 
pre-patch).  Still, the fact that I missed it means that this next idea 
is still worthwhile.

> 
> Maybe in patch 1 you should add this to fileops.h:
> #if NBDKIT_API_VERSION - 0 != 2
> # error This header requires API version 2
> #endif
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org