[Libguestfs] [RFC nbdkit PATCH 4/4] sh, eval: Add .list_exports support

Richard W.M. Jones rjones at redhat.com
Mon Aug 3 11:20:25 UTC 2020


Patches 1-3 all look quite reasonable to me.

As I think we discussed on IRC after this was posted(?) it might be
better to consider the sh plugin printing something like:

  NAMES
  name1
  name2
  ...

or perhaps

  NAMES <number-of-names>
  name1
  name2
  ...

with an alternate NAMES+DESCRIPTIONS format which interleaves each
name and description.

I wouldn't bother with parsing anything more complicated than line by
line (which means you can't have a name containing \n, but who cares).
And the format above would be extensible in future.

Weird characters in file names make ‘ls -1’ problematic, although I
don't think it's actually a security problem, so perhaps most scripts
can ignore the problem.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list