[Libguestfs] [nbdkit PATCH 3/5] api: Add nbdkit_string_intern helper

Eric Blake eblake at redhat.com
Wed Aug 26 13:56:33 UTC 2020


On 8/26/20 8:35 AM, Richard W.M. Jones wrote:

>> Time for some name bike-shedding.  How about:
>>
>> nbdkit_strdup_intern (const char *)
>> nbdkit_strndup_intern (const char *s, size_t)
>>
>> and if we need something that permits embedded NUL (right now I
>> don't have such a use) we could add
>> nbdkit_memdup_intern (const void *s, size_t)
> 
> Seems good to me.  Do you think we'll be able to get the final APIs
> into nbdkit this week?  I don't much care about finishing the
> implementation, just that any APIs we add wont need to be changed
> later.

Yes.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the Libguestfs mailing list