[Libguestfs] [PATCH nbdkit 2/2] api: Remove .list_exports from nbdkit 1.22 release.

Richard W.M. Jones rjones at redhat.com
Thu Aug 27 13:22:37 UTC 2020


On Thu, Aug 27, 2020 at 08:01:01AM -0500, Eric Blake wrote:
> On 8/27/20 7:29 AM, Richard W.M. Jones wrote:
> >During the 1.21 development cycle we added support for listing
> >exports.  However at the time that 1.22 was released we did not feel
> >the API was sufficiently finalized to commit to in a stable branch.
> >Therefore this new API was removed before 1.22 was released, but the
> >feature continues to be developed upstream and should appear in
> >nbdkit 1.24.
> >
> >Note this also hides the nbdkit*export* functions so they can only be
> >used from filters (filters do not have a stable API).
> >---
> >  plugins/eval/nbdkit-eval-plugin.pod |   2 -
> >  plugins/sh/nbdkit-sh-plugin.pod     |  52 -----------
> >  include/nbdkit-common.h             |   5 --
> >  include/nbdkit-filter.h             |   5 ++
> >  include/nbdkit-plugin.h             |   3 -
> >  tests/Makefile.am                   |   4 -
> >  server/plugins.c                    |   9 +-
> >  plugins/sh/methods.h                |   2 -
> >  plugins/eval/eval.c                 |   2 -
> >  plugins/ondemand/ondemand.c         |  51 -----------
> >  plugins/sh/methods.c                | 106 ----------------------
> >  plugins/sh/sh.c                     |   1 -
> >  plugins/sh/example.sh               |   8 --
> >  tests/test-eval-exports.sh          | 135 ----------------------------
> >  tests/test-ondemand-list.sh         |  67 --------------
> >  tests/test-layers-plugin.c          |   9 --
> >  tests/test-layers.c                 |  15 ----
> >  17 files changed, 6 insertions(+), 470 deletions(-)
> 
> Do we also want to fix the wording in docs/nbdkit-protocol.pod (to
> not mention 1.22 as the release where .list_exports was supported)
> and docs/nbdkit-plugin.pod (to not document the callback)?  The
> former could be squashed into patch 1/2, the latter is specific to
> the 1.22 stable branch.
> 
> Otherwise ACK.

Thanks yes - I fixed that and a few other problems and pushed it.
I'll announce the release later today.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list