[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] virt-v2v: Virtio-Scsi patch



On Wed, Sep 16, 2020 at 09:10:01AM +0200, Jean-Louis Dupond wrote:
> 
> On 15/09/2020 21:08, Richard W.M. Jones wrote:
> >On Tue, Sep 15, 2020 at 09:54:32AM +0200, Jean-Louis Dupond wrote:
> >>Hi,
> >>
> >>I was trying to migrate some VM's to Virtio-SCSI block devices, as
> >>this gives some advantages.
> >>
> >>While checking the virt-v2v code, I found out that it supported
> >>Virtio-SCSI, but some bits were missing.
> >>In attachment a small patch that adds the missing bits :)
> >This isn't the patch I was expecting this morning :-)  I'm definitely
> >looking forward also to the SMP changes.
> The SMP 'change' is quite stupid atm :)
> diff --git a/v2v/v2v.ml b/v2v/v2v.ml
> index 73edff2c..271e2b03 100644
> --- a/v2v/v2v.ml
> +++ b/v2v/v2v.ml
> @@ -88,6 +88,7 @@ let rec main () =
> 
>    let g = open_guestfs ~identifier:"v2v" () in
>    g#set_memsize (g#get_memsize () * 14 / 5);
> +  g#set_smp 4;
>    (* The network is only used by the unconfigure_vmware () function. *)
>    g#set_network true;
>    (match conversion_mode with

FWIW this was what I put upstream:

https://github.com/libguestfs/virt-v2v/commit/d2b64ecc67012d57e463c228f1ac5fe20c06f609

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]