[Libguestfs] [nbdkit PATCH] eval: Allow user override of 'missing'

Eric Blake eblake at redhat.com
Mon Feb 10 19:56:44 UTC 2020


On 2/10/20 1:44 PM, Eric Blake wrote:
> A comment in the code mentioned something that didn't actually work,
> but which can be useful for user-directed logging of what other
> callbacks they might want to implement.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> 
> I haven't pushed this one, becuase I'm not sure if we want it; but it
> was easy enough to whip together after an IRC question earlier today.
> 
>   plugins/eval/eval.c                 | 16 +++++++++++++---
>   plugins/eval/nbdkit-eval-plugin.pod |  6 ++++++
>   tests/test-eval.sh                  |  2 ++
>   3 files changed, 21 insertions(+), 3 deletions(-)

Missing one hunk:

diff --git i/plugins/eval/eval.c w/plugins/eval/eval.c
index 31b62bb..094cac5 100644
--- i/plugins/eval/eval.c
+++ w/plugins/eval/eval.c
@@ -72,6 +72,7 @@ static const char *known_methods[] = {
    "flush",
    "get_size",
    "is_rotational",
+  "missing",
    "open",
    "pread",
    "pwrite",


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the Libguestfs mailing list