[Libguestfs] [libnbd PATCH 1/1] generator: Add support for NBD_INFO_INIT_STATE extension
Eric Blake
eblake at redhat.com
Mon Feb 10 22:31:26 UTC 2020
On 2/10/20 4:24 PM, Richard W.M. Jones wrote:
>
> The idea and patch is fine, but I wonder if it would be more useful to
> callers if it was exposed as two separate APIs. Callers would then
> not need to deal with masking out unknown flags, and it works more
> like the other is_* / can_* ("flag calls") we already have.
Fair point, especially since I exposed it in nbdkit as two callbacks for
setting the bits. Naming suggestions? Maybe nbd_is_init_sparse and
nbd_is_init_zero ?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
More information about the Libguestfs
mailing list