[Libguestfs] [nbdkit PATCH 03/10] filters: Wire up filter support for NBD_INFO_INIT_STATE

Richard W.M. Jones rjones at redhat.com
Tue Feb 11 10:40:56 UTC 2020


On Mon, Feb 10, 2020 at 03:43:56PM -0600, Eric Blake wrote:
> diff --git a/filters/noextents/noextents.c b/filters/noextents/noextents.c
> index e6ac33b..091f30b 100644
> --- a/filters/noextents/noextents.c
> +++ b/filters/noextents/noextents.c
> @@ -1,5 +1,5 @@
>  /* nbdkit
> - * Copyright (C) 2019 Red Hat Inc.
> + * Copyright (C) 2019-2020 Red Hat Inc.
>   *
>   * Redistribution and use in source and binary forms, with or without
>   * modification, are permitted provided that the following conditions are
> @@ -41,10 +41,26 @@ noextents_can_extents (struct nbdkit_next_ops *next_ops, void *nxdata,
>    return 0;
>  }
> 
> +static int
> +noextents_init_sparse (struct nbdkit_next_ops *next_ops, void *nxdata,
> +                       void *handle)
> +{
> +  return 0;
> +}
> +
> +static int
> +noextents_init_zero (struct nbdkit_next_ops *next_ops, void *nxdata,
> +                     void *handle)
> +{
> +  return 0;
> +}

Is this true?  If so it could at least be worth a comment in the code
about why because I'm not clear about it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list