[Libguestfs] [PATCH nbdkit v2 0/3] server: Remove explicit connection parameter.

Eric Blake eblake at redhat.com
Tue Feb 11 20:18:15 UTC 2020


On 2/11/20 11:39 AM, Richard W.M. Jones wrote:
> v1 was here:
> https://www.redhat.com/archives/libguestfs/2020-February/msg00081.html
> 
> v2 replaces
>    struct connection *conn = GET_CONN;
> with
>    GET_CONN;
> which sets conn implicitly and asserts that it is non-NULL.
> If we actually want to test if conn is non-NULL or behave
> differently, then you must use threadlocal_get_conn() instead,
> and some existing uses do that.

LGTM

> 
> Rich.
> 
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the Libguestfs mailing list