[Libguestfs] [PATCH v2v] openstack: Increase Cinder volume attach timeout to 5 minutes (RHBZ#1685032).

[Pino Toscano]

On Tuesday, 4 February 2020 15:41:33 CET Richard W.M. Jones wrote:
> In some cases we have observed the time taken for a Cinder volume to
> attach to the conversion appliance can be longer than the current 60
> seconds.  Increase the timeout to 5 minutes.
> 
> Thanks: Ming Xie.
> ---
>  v2v/output_openstack.ml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml
> index caaedf452..e395ccb37 100644
> --- a/v2v/output_openstack.ml
> +++ b/v2v/output_openstack.ml
> @@ -38,7 +38,7 @@ let openstack_binary = "openstack"
>  let available_timeout = 300 (* seconds *)
>  
>  (* Timeout waiting for Cinder volumes to attach to the appliance. *)
> -let attach_timeout = 60 (* seconds *)
> +let attach_timeout = 300 (* seconds *)

While this seems a good attempt to avoid timeouts due to slow network
or OpenStack interactions, I'd also raise the sleep amount (defaults
is 2 seconds) in the with_timeout where this attach_timeout is used,
for example to 5 seconds. This way, if Cinder/the appliance/whatever
is overloaded, we will not overload it too with 2s bursts of queries.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200214/f1d9ad73/attachment.sig>