[Libguestfs] [nbdkit PATCH] vddk: Make 'file=' a magic key

Eric Blake eblake at redhat.com
Mon Feb 17 12:55:55 UTC 2020


On 2/17/20 6:48 AM, Richard W.M. Jones wrote:
> On Mon, Feb 17, 2020 at 12:45:58PM +0000, Richard W.M. Jones wrote:
>> On Thu, Feb 13, 2020 at 04:49:59PM -0600, Eric Blake wrote:
>>> Since it is required, it might as well be magic ;)
>>>
>>> Signed-off-by: Eric Blake <eblake at redhat.com>
>>> ---
>>>
>>> As written, applies on top of my v3 patch for dlopen; but it would
>>> be easy enough to rebase and take this one now even if we aren't
>>> sure about the dlopen stuff
>>>

>>> -nbdkit vddk libdir=.libs \
>>> -  file=/dev/null --run ':' 2> test-vddk.err || :
>>> +nbdkit vddk libdir=.libs /dev/null --run ':' 2> test-vddk.err || :
>>>   cat test-vddk.err
>>>
>>>   grep '/.libs/nosuch' test-vddk.err
>>
>> Yup, this is fine, ACK.
> 
> Actually it doesn't apply - maybe depends on something else?

Yep, it (now) depends on my v4 dlopen series, unless I rebase it to 
apply first.

> 
> Anyway the change itself is still fine.

Okay. Should I wait for your review of the dlopen stuff, or go ahead 
with this one now?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the Libguestfs mailing list