[Libguestfs] [nbdkit PATCH] vddk: Drop support for VDDK 5.1.1

[Richard W.M. Jones]

On Tue, Feb 18, 2020 at 12:32:50PM -0600, Eric Blake wrote:
> That version depends on libexpat.so but does not ship it, and it
> appears that VMware no longer supports it.  Since VDDK 5.5.5 (the next
> oldest version) dropped support for 32-bit platforms, we can slightly
> simplify our code by documenting our minimum supported version.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>

Yes, in general let's do this.

However we also should change the test in configure.ac (see around
lines 899ff.)

> diff --git a/plugins/vddk/nbdkit-vddk-plugin.pod b/plugins/vddk/nbdkit-vddk-plugin.pod
> index 7ea2e797..766db302 100644
> --- a/plugins/vddk/nbdkit-vddk-plugin.pod
> +++ b/plugins/vddk/nbdkit-vddk-plugin.pod
> @@ -451,7 +451,8 @@ For more information see L<https://bugzilla.redhat.com/1614276>.
> 
>  =head1 SUPPORTED VERSIONS OF VDDK
> 
> -This plugin requires VDDK E<ge> 5.1.1.
> +This plugin requires VDDK E<ge> 5.5.5, which in turn means that it
> +is only supported on 64-bit platforms.

Only on x86-64.  I think we should say that.  VMware internally have
an aarch64 version but AFAIK it has never been released.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v