[Libguestfs] [PATCH libnbd] python: Add AIO buffer is_zero method.

Eric Blake eblake at redhat.com
Thu Jan 30 14:16:30 UTC 2020


On 1/30/20 8:05 AM, Richard W.M. Jones wrote:
> Fast testing whether the AIO buffer (or regions within it) contain all
> zeroes, which allows Python code to quickly do sparsification when
> copying.
> 
> This includes the iszero.h header from nbdkit which is distributed
> under a compatible license.
> ---
>   common/include/Makefile.am  |  5 +--
>   common/include/iszero.h     | 63 +++++++++++++++++++++++++++++++++++++
>   generator/generator         | 17 ++++++++--
>   python/Makefile.am          |  3 +-
>   python/handle.c             | 47 +++++++++++++++++++++++++++
>   python/t/580-aio-is-zero.py | 53 +++++++++++++++++++++++++++++++
>   6 files changed, 183 insertions(+), 5 deletions(-)

ACK.


> +++ b/common/include/Makefile.am
> @@ -1,5 +1,5 @@
>   # nbd client library in userspace
> -# Copyright (C) 2013-2019 Red Hat Inc.
> +# Copyright (C) 2013-2020 Red Hat Inc.

Unrelated question: we are just now making our first libnbd commits of 
2020.  Should we have the 'nbdsh --version' output a copyright date? And 
if so, should we automate the process to automatically update it to the 
current year, rather than remembering to touch files manually when 
making the first commit in a year?  Should we manually update the 
copyright date in ALL files in a single pass, rather than one-off edits 
as we make per-file changes (if so, the gnulib project has a nice script 
for automating a tree-wide copyright range update).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the Libguestfs mailing list