[Libguestfs] [PATCH Fedora libguestfs] Don't depend on libvirt-daemon-kvm monolith.

[Daniel P. Berrangé]

On Fri, Jan 10, 2020 at 03:10:51PM +0100, Pino Toscano wrote:
> On Friday, 10 January 2020 15:05:33 CET Richard W.M. Jones wrote:
> > libguestfs usually needs qemu.  However it only requires an emulator
> > for the same architecture, not for all architectures.
> > libvirt-daemon-kvm pulls in qemu which pulls in emulators for all
> > architectures, as well as a bunch of other stuff we don't need at all
> > like network interface support and nwfilter.
> > 
> > There are no Fedora TCG-only arches, so drop the conditional section.
> > 
> > I also made support for storage backends "Recommends" so that people
> > can get rid of things like Gluster if they want.
> > ---
> >  libguestfs.spec | 14 +++++++++-----
> >  1 file changed, 9 insertions(+), 5 deletions(-)
> > 
> > diff --git a/libguestfs.spec b/libguestfs.spec
> > index 0d32ef0..71f97c6 100644
> > --- a/libguestfs.spec
> > +++ b/libguestfs.spec
> > @@ -211,12 +211,16 @@ Requires:      fuse
> >  # For core disk-create API.
> >  Requires:      /usr/bin/qemu-img
> >  
> > -# For libvirt backend.
> > -%ifarch %{ix86} x86_64 %{arm} aarch64
> > -Requires:      libvirt-daemon-kvm >= 0.10.2-3
> > -%else
> > +# For qemu direct and libvirt backends.
> > +Requires:      qemu-kvm-core
> > +Requires:      libvirt-daemon-driver-qemu
> 
> This is OK.
> 
> > +Recommends:    libvirt-daemon-driver-storage-disk
> > +Recommends:    libvirt-daemon-driver-storage-gluster
> > +Recommends:    libvirt-daemon-driver-storage-iscsi
> > +Recommends:    libvirt-daemon-driver-storage-logical
> > +Recommends:    libvirt-daemon-driver-storage-rbd
> > +Recommends:    libvirt-daemon-driver-storage-scsi
> 
> This is not needed, libguestfs does not need these libvirt drivers.

Was this perhaps supposed to be qemu-block-{curl,gluster,iscsi,rbd,etc)
to get the QEMU block drivers ?

> 
> >  Requires:      libvirt-daemon-qemu >= 0.10.2-3
> 
> This still requires qemu, which in turns requires all the qemu-system-*
> packages, so it has to go too.
> 
> In addition to that, we need at least the libvirt secret driver, so
> require also libvirt-daemon-driver-secret.
> 
> -- 
> Pino Toscano



> _______________________________________________
> Libguestfs mailing list
> Libguestfs at redhat.com
> https://www.redhat.com/mailman/listinfo/libguestfs


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|