[Libguestfs] [PATCH 6/7] python: improve errors in inspect_vm example

Pino Toscano ptoscano at redhat.com
Fri Jan 10 14:28:58 UTC 2020


When validating user input, print an error message and exit, instead of
either asserting or raising a non-existing exception.
---
 python/examples/inspect_vm.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/python/examples/inspect_vm.py b/python/examples/inspect_vm.py
index 22cd70f28..dcf3b538c 100644
--- a/python/examples/inspect_vm.py
+++ b/python/examples/inspect_vm.py
@@ -3,7 +3,9 @@
 import sys
 import guestfs
 
-assert(len(sys.argv) == 2)
+if len(sys.argv) < 2:
+    print("inspect_vm: missing disk image to inspect", file=sys.stderr)
+    sys.exit(1)
 disk = sys.argv[1]
 
 # All new Python code should pass python_return_dict=True
@@ -21,7 +23,8 @@ g.launch()
 # Ask libguestfs to inspect for operating systems.
 roots = g.inspect_os()
 if len(roots) == 0:
-    raise(Error("inspect_vm: no operating systems found"))
+    print("inspect_vm: no operating systems found", file=sys.stderr)
+    sys.exit(1)
 
 for root in roots:
     print("Root device: %s" % root)
-- 
2.24.1




More information about the Libguestfs mailing list