[Libguestfs] [PATCH] Link .mli files corresponding to autorgenerated .ml files into builddir

[Pino Toscano]

On Tuesday, 14 January 2020 12:31:24 CET Hilko Bengen wrote:
> * Pino Toscano:
> 
> > I do not think this is the correct approach.  See my analysis here:
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946594#46
> 
> This issue is for a different problem that appeared on some
> architectures after I forced *config.ml to be regenerated for the Debian
> builds of libguestfs 1.40.2, see
> <https://buildd.debian.org/status/logs.php?pkg=libguestfs&ver=1%3A1.40.2-4&suite=sid>.

The issue is actually the same: I was able to reproduce it locally on
git master at that time, and it showed the same result.

common/mlstdutils/guestfs_config.ml, daemon/daemon_config.ml, and
v2v/config.ml are generated by configure, so shipping them in the
tarball was wrong to begin with -- see e.g. commit 323909d92ee6810.

After not shipping them, the issue become for the dependency resolution
to match .ml <=> .mli in different directories (one in the builddir,
the other in the srcdir). The suggested fix by Vincent Danjean in the
Debian bug worked for that -- see commit 4cd801dcff1393f.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200114/69734fc3/attachment.sig>