[Libguestfs] [PATCH] add default (unversioned) directory for guest agent on EL

[Pino Toscano]

On Thursday, 16 January 2020 15:02:52 CET Tomáš Golembiovský wrote:
> There was no source directory for EL8 guest agent (only EL6 and EL7).
> 
> RHBZ#1791802
> 
> Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
> ---
>  v2v/windows_virtio.ml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml
> index 5ec7664b..6ddc488a 100644
> --- a/v2v/windows_virtio.ml
> +++ b/v2v/windows_virtio.ml
> @@ -192,7 +192,7 @@ and install_linux_tools g inspect =
>        (match inspect.i_major_version with
>         | 6 -> Some "el6"
>         | 7 -> Some "el7"
> -       | _ -> None)
> +       | _ -> Some "el")

I do not agree with this solution: the major series of EL systems are
very different in the base OS/toolchain, so I do not think installing
a (say) RHEL 8 package on a greater version is a good idea.

IMHO changing it to "elX" where X is the major version of EL is a
better solution (and simplifies that code a bit).

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200116/ebb3868a/attachment.sig>