[Libguestfs] virt-v2v: error: redefinition of 'glib_autoptr_clear_OsinfoList'

[Pino Toscano]

On Monday, 1 June 2020 04:17:00 CEST Kevin Locke wrote:
> Hi All,
> 
> I'm attempting to compile virt-v2v 1.42.0 on Debian testing.  With gcc
> 9.3.0, libosinfo 1.7.1, and glib 2.64.2, `./configure && make` fails
> on libosinfo-c.c with the following error message:
> 
> -8<--------------------------------------------------------------------
> In file included from /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:9,
>                  from /usr/include/glib-2.0/glib/gtypes.h:32,
>                  from /usr/include/glib-2.0/glib/galloca.h:32,
>                  from /usr/include/glib-2.0/glib.h:30,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:28,
>                  from /usr/include/glib-2.0/glib-object.h:22,
>                  from /usr/include/libosinfo-1.0/osinfo/osinfo.h:28,
>                  from libosinfo-c.c:25:
> /usr/include/glib-2.0/glib/gmacros.h:1028:49: error: redefinition of 'glib_autoptr_clear_OsinfoList'
>  1028 | #define _GLIB_AUTOPTR_CLEAR_FUNC_NAME(TypeName) glib_autoptr_clear_##TypeName
>       |                                                 ^~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gmacros.h:1044:36: note: in expansion of macro '_GLIB_AUTOPTR_CLEAR_FUNC_NAME'
>  1044 |   static G_GNUC_UNUSED inline void _GLIB_AUTOPTR_CLEAR_FUNC_NAME(TypeName) (TypeName *_ptr)                     \
>       |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gmacros.h:1061:3: note: in expansion of macro '_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS'
>  1061 |   _GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS(TypeName, TypeName, func)
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> libosinfo-c.c:47:1: note: in expansion of macro 'G_DEFINE_AUTOPTR_CLEANUP_FUNC'
>    47 | G_DEFINE_AUTOPTR_CLEANUP_FUNC(OsinfoList, g_object_unref)
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gmacros.h:1028:49: note: previous definition of 'glib_autoptr_clear_OsinfoList' was here
>  1028 | #define _GLIB_AUTOPTR_CLEAR_FUNC_NAME(TypeName) glib_autoptr_clear_##TypeName
>       |                                                 ^~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gmacros.h:1044:36: note: in expansion of macro '_GLIB_AUTOPTR_CLEAR_FUNC_NAME'
>  1044 |   static G_GNUC_UNUSED inline void _GLIB_AUTOPTR_CLEAR_FUNC_NAME(TypeName) (TypeName *_ptr)                     \
>       |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gmacros.h:1056:3: note: in expansion of macro '_GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS'
>  1056 |   _GLIB_DEFINE_AUTOPTR_CLEANUP_FUNCS(ModuleObjName, ParentName, _GLIB_AUTOPTR_CLEAR_FUNC_NAME(ParentName))
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/gobject/gtype.h:1500:3: note: in expansion of macro '_GLIB_DEFINE_AUTOPTR_CHAINUP'
>  1500 |   _GLIB_DEFINE_AUTOPTR_CHAINUP (ModuleObjName, ParentName)                                               \
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/libosinfo-1.0/osinfo/osinfo_list.h:33:1: note: in expansion of macro 'G_DECLARE_DERIVABLE_TYPE'
>    33 | G_DECLARE_DERIVABLE_TYPE(OsinfoList, osinfo_list, OSINFO, LIST, GObject)
>       | ^~~~~~~~~~~~~~~~~~~~~~~
> -8<--------------------------------------------------------------------
> 
> The full build log is available at
> https://kevinlocke.name/misc/virt-v2v/virt-v2v-1.42.0-buildlog.txt
> 
> Is this a version incompatibility or something I've misconfigured?
> If someone could point me in the right direction, I'd appreciate it.

Uhm, that's indeed a problem, and apparently due to a bug in libosinfo
and a change in glib.

I just posted a change that should fix this, see its message for a
longer explanation of the issue:
https://www.redhat.com/archives/libguestfs/2020-June/msg00003.html
tested on Fedora 31 and Debian testing.

I mentioned your name in the commit message to give you credit for
the report, is it OK for you? (If not, I will remove it before
pushing.)

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200601/abe4db19/attachment.sig>